> From: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx> > Sent: Thursday, February 16, 2023 5:33 AM > Subject: Re: [PATCH intel-next v4 8/8] i40e: add support for XDP multi-buffer > Rx > > On 2/15/2023 6:51 AM, Lorenzo Bianconi wrote: > >> This patch adds multi-buffer support for the i40e_driver. > >> > > > > [...] > > > >> > >> netdev->features &= ~NETIF_F_HW_TC; > >> netdev->xdp_features = NETDEV_XDP_ACT_BASIC | > NETDEV_XDP_ACT_REDIRECT | > >> - NETDEV_XDP_ACT_XSK_ZEROCOPY; > >> + NETDEV_XDP_ACT_XSK_ZEROCOPY | > >> + NETDEV_XDP_ACT_RX_SG; > > > > Hi Tirthendu, > > > > I guess we should set it just for I40E_VSI_MAIN, I posted a patch yesterday > > to fix it: > > > https://patchwork.kernel.org/project/netdevbpf/patch/f2b537f86b34fc176f > bc6b3d249b46a20a87a2f3.1676405131.git.lorenzo@xxxxxxxxxx/ > > > > can you please rebase on top of it? > > Jakub, > > I believe you are planning on taking Lorenzo's ice [1] and i40e [2] > patch based on the comment of taking follow-ups directly [3]? > > If so, Tirthendu, I'll rebase after this is pulled by netdev, then if > you can base on next-queue so everything will apply nicely. > I have rebased it and will send the v5 once the 24hr curfew on sending patches is over. Regards Tirthendu > Thanks, > Tony > > > Regards, > > Lorenzo > > [1] > https://lore.kernel.org/all/8a4781511ab6e3cd280e944eef69158954f1a15f.167 > 6385351.git.lorenzo@xxxxxxxxxx/ > [2] > https://lore.kernel.org/all/f2b537f86b34fc176fbc6b3d249b46a20a87a2f3.1676 > 405131.git.lorenzo@xxxxxxxxxx/ > [3] https://lore.kernel.org/all/20230213172358.7df0f07c@xxxxxxxxxx/