Jiapeng Chong writes:
The function within is defined in the main.c file, but not called elsewhere, so remove this unused function.
Huh? It's used by __module_text_address(), no?
kernel/module/main.c:3007:19: warning: unused function 'within'. Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4035 Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> --- kernel/module/main.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index c598f11e7016..062065568b40 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -3004,11 +3004,6 @@ SYSCALL_DEFINE3(finit_module, int, fd, const char __user *, uargs, int, flags) return load_module(&info, uargs, flags); } -static inline int within(unsigned long addr, void *start, unsigned long size) -{ - return ((void *)addr >= start && (void *)addr < start + size); -} - /* Keep in sync with MODULE_FLAGS_BUF_SIZE !!! */ char *module_flags(struct module *mod, char *buf, bool show_state) { -- 2.20.1.7.g153144c
