On Mon, Feb 13, 2023 at 04:40:11PM -0800, Dave Marchevsky wrote: > > +struct bpf_rb_node *bpf_rbtree_remove(struct bpf_rb_root *root, struct bpf_rb_node *node) ... > +void bpf_rbtree_add(struct bpf_rb_root *root, struct bpf_rb_node *node, > + bool (less)(struct bpf_rb_node *a, const struct bpf_rb_node *b)) > +{ > + __bpf_rbtree_add(root, node, (void *)less); > +} > + > +struct bpf_rb_node *bpf_rbtree_first(struct bpf_rb_root *root) __bpf_kfunc annotations were missing. I've added them while applying. The rest looks great. Very nice milestone.