Hi Hangbin Liu,
On 10/02/2023 10:32, Hangbin Liu wrote:
> Some distros may not enable mptcp by default. Enable it before start the
> mptcp server. To use the {read/write}_int_sysctl() functions, I moved
> them to test_progs.c
>
> Fixes: 8039d353217c ("selftests/bpf: Add MPTCP test base")
> Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxx>
> ---
> .../testing/selftests/bpf/prog_tests/mptcp.c | 15 ++++++-
Thank you for the patch!
The modifications linked to MPTCP look good to me.
But I don't think it is needed here: I maybe didn't look properly at
'bpf/test_progs.c' file but I think each program from 'prog_tests'
directory is executed in a dedicated netns, no?
I don't have an environment ready to validate that but if yes, it means
that on a "vanilla" kernel, net.mptcp.enabled sysctl knob should be set
to 1. In this case, this modification would be specific to these distros
patching MPTCP code to disable it by default. It might then be better to
add this patch next to the one disabling MPTCP by default, no? (or
revert it to have MPTCP available by default for the applications asking
for it :) )
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
