XSK transmission will reuse this procedure, and will also need the logic
for setting the "final" bit of a TX BD, based on tx_swbd->is_eof.
Not sure why this was left to be done by the caller of
enetc_xdp_map_tx_buff(), but move it inside.
Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
---
drivers/net/ethernet/freescale/enetc/enetc.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index e4552acf762c..dee432cacf85 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -1263,6 +1263,10 @@ static void enetc_xdp_map_tx_buff(struct enetc_bdr *tx_ring, int i,
txbd->buf_len = cpu_to_le16(tx_swbd->len);
txbd->frm_len = cpu_to_le16(frm_len);
+ /* last BD needs 'F' bit set */
+ if (tx_swbd->is_eof)
+ txbd->flags = ENETC_TXBD_FLAGS_F;
+
memcpy(&tx_ring->tx_swbd[i], tx_swbd, sizeof(*tx_swbd));
}
@@ -1286,17 +1290,7 @@ static bool enetc_xdp_tx(struct enetc_bdr *tx_ring,
i = tx_ring->next_to_use;
for (k = 0; k < num_tx_swbd; k++) {
- struct enetc_tx_swbd *xdp_tx_swbd = &xdp_tx_arr[k];
-
- enetc_xdp_map_tx_buff(tx_ring, i, xdp_tx_swbd, frm_len);
-
- /* last BD needs 'F' bit set */
- if (xdp_tx_swbd->is_eof) {
- union enetc_tx_bd *txbd = ENETC_TXBD(*tx_ring, i);
-
- txbd->flags = ENETC_TXBD_FLAGS_F;
- }
-
+ enetc_xdp_map_tx_buff(tx_ring, i, &xdp_tx_arr[k], frm_len);
enetc_bdr_idx_inc(tx_ring, &i);
}
--
2.34.1
