v->rx_ring.stats.bytes is apparently only used for interrupt coalescing, not for printing to ethtool -S. I am unable to find a functional problem caused by the lack of updating this counter, but it is updated from the stack NAPI poll routine, so update it from the XDP one too. Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx> --- drivers/net/ethernet/freescale/enetc/enetc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c index fe6a3a531a0a..e4552acf762c 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -1461,7 +1461,8 @@ static void enetc_add_rx_buff_to_xdp(struct enetc_bdr *rx_ring, int i, static void enetc_build_xdp_buff(struct enetc_bdr *rx_ring, u32 bd_status, union enetc_rx_bd **rxbd, int *i, - int *buffs_missing, struct xdp_buff *xdp_buff) + int *buffs_missing, struct xdp_buff *xdp_buff, + int *rx_byte_cnt) { u16 size = le16_to_cpu((*rxbd)->r.buf_len); @@ -1469,6 +1470,7 @@ static void enetc_build_xdp_buff(struct enetc_bdr *rx_ring, u32 bd_status, enetc_map_rx_buff_to_xdp(rx_ring, *i, xdp_buff, size); (*buffs_missing)++; + (*rx_byte_cnt) += size; enetc_rxbd_next(rx_ring, rxbd, i); /* not last BD in frame? */ @@ -1483,6 +1485,7 @@ static void enetc_build_xdp_buff(struct enetc_bdr *rx_ring, u32 bd_status, enetc_add_rx_buff_to_xdp(rx_ring, *i, size, xdp_buff); (*buffs_missing)++; + (*rx_byte_cnt) += size; enetc_rxbd_next(rx_ring, rxbd, i); } } @@ -1571,7 +1574,7 @@ static int enetc_clean_rx_ring_xdp(struct enetc_bdr *rx_ring, orig_i = i; enetc_build_xdp_buff(rx_ring, bd_status, &rxbd, &i, - &buffs_missing, &xdp_buff); + &buffs_missing, &xdp_buff, &rx_byte_cnt); xdp_act = bpf_prog_run_xdp(prog, &xdp_buff); -- 2.34.1