On 2/3/23 7:47 PM, John Fastabend wrote:
tong@ wrote:
From: Tonghao Zhang <tong@xxxxxxxxxxxxx>
This patch introduce a stats update helper to simplify codes.
Signed-off-by: Tonghao Zhang <tong@xxxxxxxxxxxxx>
Cc: Alexei Starovoitov <ast@xxxxxxxxxx>
Cc: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
Cc: Andrii Nakryiko <andrii@xxxxxxxxxx>
Cc: Martin KaFai Lau <martin.lau@xxxxxxxxx>
Cc: Song Liu <song@xxxxxxxxxx>
Cc: Yonghong Song <yhs@xxxxxx>
Cc: John Fastabend <john.fastabend@xxxxxxxxx>
Cc: KP Singh <kpsingh@xxxxxxxxxx>
Cc: Stanislav Fomichev <sdf@xxxxxxxxxx>
Cc: Hao Luo <haoluo@xxxxxxxxxx>
Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
Cc: Hou Tao <houtao1@xxxxxxxxxx>
---
include/linux/filter.h | 22 +++++++++++++++-------
kernel/bpf/trampoline.c | 10 +---------
2 files changed, 16 insertions(+), 16 deletions(-)
Seems fine but I'm not sure it makes much difference.
I also don't think it is needed. There are only two places. Also, it is not
encouraged to collect more stats. Refactoring it is not going to help in the future.
