Hi Arnaldo, On Thu, Feb 2, 2023 at 12:27 PM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote: > > Em Wed, Feb 01, 2023 at 09:04:53PM -0800, Namhyung Kim escreveu: > > This is a preparation work to support complex keys of BPF maps. Now it > > has single value key according to the aggregation mode like stack_id or > > pid. But we want to use a combination of those keys. > > > > Then lock_contention_read() should still aggregate the result based on > > the key that was requested by user. The other key info will be used for > > filtering. > > > > So instead of creating a lock_stat entry always, Check if it's already > > there using lock_stat_find() first. > > Hey, try building without libtraceevent-devel installed, should be > equivalent to NO_LIBTRACEEVENT=1. > > At this point I think you should move bpf_lock_contention.o to inside > that CONFIG_LIBTRACEEVENT if block. > > perf-$(CONFIG_PERF_BPF_SKEL) += bpf_lock_contention.o > > ifeq ($(CONFIG_LIBTRACEEVENT),y) > perf-$(CONFIG_PERF_BPF_SKEL) += bpf_kwork.o > endif > > I'm removing this series from tmp.perf/core for now. Thanks for the suggestion. I've tested it builds with the change. Will send v2. Thanks, Namhyung
