On Wed, Jan 25, 2023 at 1:39 PM Ilya Leoshkevich <iii@xxxxxxxxxxxxx> wrote: > > Hi, > > This series implements poke, trampoline, kfunc, mixing subprogs and > tailcalls, and fixes a number of tests on s390x. > > The following failures still remain: > > #52 core_read_macros:FAIL > Uses BPF_PROBE_READ(), shouldn't there be BPF_PROBE_READ_KERNEL()? BPF_PROBE_READ(), similarly to BPF_CORE_READ() both use bpf_probe_read_kernel() internally, as it's most common use case. We have separate BPF_PROBE_READ_USER() and BPF_CORE_READ_USER() for when bpf_probe_read_user() has to be used. > > #82 get_stack_raw_tp:FAIL > get_stack_print_output:FAIL:user_stack corrupted user stack > Known issue: > We cannot reliably unwind userspace on s390x without DWARF. like in principle, or frame pointers (or some equivalent) needs to be configured for this to work? Asking also in the context of [0], where s390x was excluded. If there is actually a way to enable frame pointer-based stack unwinding on s390x, would be nice to hear from an expert. [0] https://pagure.io/fesco/issue/2923 > > #101 ksyms_module:FAIL > address of kernel function bpf_testmod_test_mod_kfunc is out of range > Known issue: > Kernel and modules are too far away from each other on s390x. > > #167 sk_assign:FAIL > Uses legacy map definitions in 'maps' section. Hm.. assuming new enough iproute2, new-style .maps definition should be supported, right? Let's convert map definition? > > #190 stacktrace_build_id:FAIL > Known issue: > We cannot reliably unwind userspace on s390x without DWARF. > > #211 test_bpffs:FAIL > iterators.bpf.c is broken on s390x, it uses BPF_CORE_READ(), shouldn't > there be BPF_CORE_READ_KERNEL()? BPF_CORE_READ() is that, so must be something else > > #218 test_profiler:FAIL > A lot of BPF_PROBE_READ() usages. ditto, something else > > #281 xdp_metadata:FAIL > See patch 24. > > #284 xdp_synproxy:FAIL > Verifier error: > ; value = bpf_tcp_raw_gen_syncookie_ipv4(hdr->ipv4, hdr->tcp, > 281: (79) r1 = *(u64 *)(r10 -80) ; R1_w=pkt(off=14,r=74,imm=0) R10=fp0 > 282: (bf) r2 = r8 ; R2_w=pkt(id=5,off=14,r=74,umax=60,var_off=(0x0; 0x3c)) R8=pkt(id=5,off=14,r=74,umax=60,var_off=(0x0; 0x3c)) > 283: (79) r3 = *(u64 *)(r10 -104) ; R3_w=scalar(umax=60,var_off=(0x0; 0x3c)) R10=fp0 > 284: (85) call bpf_tcp_raw_gen_syncookie_ipv4#204 > invalid access to packet, off=14 size=0, R2(id=5,off=14,r=74) > R2 offset is outside of the packet third arg to bpf_tcp_raw_gen_syncookie_ipv4() is defined as ARG_CONST_SIZE, so is required to be strictly positive, which doesn't seem to be "proven" to verifier. Please provided bigger log, it might another instance of needing to sprinkle barrier_var() around. And maybe thinking about using ARG_CONST_SIZE_OR_ZERO instead of ARG_CONST_SIZE. > > None of these seem to be due to the new changes. > > Best regards, > Ilya > > Ilya Leoshkevich (24): > selftests/bpf: Fix liburandom_read.so linker error > selftests/bpf: Fix symlink creation error > selftests/bpf: Fix fexit_stress on s390x > selftests/bpf: Fix trampoline_count on s390x > selftests/bpf: Fix kfree_skb on s390x > selftests/bpf: Set errno when urand_spawn() fails > selftests/bpf: Fix decap_sanity_ns cleanup > selftests/bpf: Fix verify_pkcs7_sig on s390x > selftests/bpf: Fix xdp_do_redirect on s390x > selftests/bpf: Fix cgrp_local_storage on s390x > selftests/bpf: Check stack_mprotect() return value > selftests/bpf: Increase SIZEOF_BPF_LOCAL_STORAGE_ELEM on s390x > selftests/bpf: Add a sign-extension test for kfuncs > selftests/bpf: Fix test_lsm on s390x > selftests/bpf: Fix test_xdp_adjust_tail_grow2 on s390x > selftests/bpf: Fix vmlinux test on s390x > libbpf: Read usdt arg spec with bpf_probe_read_kernel() > s390/bpf: Fix a typo in a comment > s390/bpf: Add expoline to tail calls > s390/bpf: Implement bpf_arch_text_poke() > bpf: btf: Add BTF_FMODEL_SIGNED_ARG flag > s390/bpf: Implement arch_prepare_bpf_trampoline() > s390/bpf: Implement bpf_jit_supports_subprog_tailcalls() > s390/bpf: Implement bpf_jit_supports_kfunc_call() > > arch/s390/net/bpf_jit_comp.c | 708 +++++++++++++++++- > include/linux/bpf.h | 8 + > include/linux/btf.h | 15 +- > kernel/bpf/btf.c | 16 +- > net/bpf/test_run.c | 9 + > tools/lib/bpf/usdt.bpf.h | 33 +- > tools/testing/selftests/bpf/Makefile | 7 +- > tools/testing/selftests/bpf/netcnt_common.h | 6 +- > .../selftests/bpf/prog_tests/bpf_cookie.c | 6 +- > .../bpf/prog_tests/cgrp_local_storage.c | 2 +- > .../selftests/bpf/prog_tests/decap_sanity.c | 2 +- > .../selftests/bpf/prog_tests/fexit_stress.c | 6 +- > .../selftests/bpf/prog_tests/kfree_skb.c | 2 +- > .../selftests/bpf/prog_tests/kfunc_call.c | 1 + > .../selftests/bpf/prog_tests/test_lsm.c | 3 +- > .../bpf/prog_tests/trampoline_count.c | 4 + > tools/testing/selftests/bpf/prog_tests/usdt.c | 1 + > .../bpf/prog_tests/verify_pkcs7_sig.c | 9 + > .../bpf/prog_tests/xdp_adjust_tail.c | 7 +- > .../bpf/prog_tests/xdp_do_redirect.c | 4 + > .../selftests/bpf/progs/kfunc_call_test.c | 18 + > tools/testing/selftests/bpf/progs/lsm.c | 7 +- > .../bpf/progs/test_verify_pkcs7_sig.c | 12 +- > .../selftests/bpf/progs/test_vmlinux.c | 4 +- > .../bpf/progs/test_xdp_adjust_tail_grow.c | 8 +- > 25 files changed, 816 insertions(+), 82 deletions(-) > > -- > 2.39.1 >
