Re: [PATCH bpf-next v2 2/2] selftests/bpf: Calls bpf_setsockopt() on a ktls enabled socket.

[Kui-Feng Lee <sinquersw@xxxxxxxxx>]

On 1/25/23 10:09, Martin KaFai Lau wrote:
> On 1/24/23 10:12 AM, Kui-Feng Lee wrote: index 
> 9523333b8905..027d95755f9f 100644
.... skip ....
> > --- a/tools/testing/selftests/bpf/progs/setget_sockopt.c
> > +++ b/tools/testing/selftests/bpf/progs/setget_sockopt.c
> > @@ -6,6 +6,8 @@
> >   #include <bpf/bpf_core_read.h>
> >   #include <bpf/bpf_helpers.h>
> >   #include <bpf/bpf_tracing.h>
> > +#define BPF_PROG_TEST_TCP_HDR_OPTIONS
> > +#include "test_tcp_hdr_options.h"
>
> Instead of having dependency on another test's header,
>
> >     #ifndef ARRAY_SIZE
> >   #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
> > @@ -22,6 +24,7 @@ int nr_active;
> >   int nr_connect;
> >   int nr_binddev;
> >   int nr_socket_post_create;
> > +int nr_fin_wait1;
> >     struct sockopt_test {
> >       int opt;
> > @@ -386,6 +389,11 @@ int skops_sockopt(struct bpf_sock_ops *skops)
> >           nr_passive += !(bpf_test_sockopt(skops, sk) ||
> >                   test_tcp_maxseg(skops, sk) ||
> >                   test_tcp_saved_syn(skops, sk));
> > +        set_hdr_cb_flags(skops, BPF_SOCK_OPS_STATE_CB_FLAG);
>
> how about directly doing this:
>                 bpf_sock_ops_cb_flags_set(skops,
> skops->bpf_sock_ops_cb_flags |
> BPF_SOCK_OPS_STATE_CB_FLAG);


Sure! It makes sense.


> > +        break;
> > +    case BPF_SOCK_OPS_STATE_CB:
> > +        if (skops->args[1] == BPF_TCP_CLOSE_WAIT)
> > +            nr_fin_wait1 += !bpf_test_sockopt(skops, sk);
> >           break;
> >       }