On Fri, 20 Jan 2023 18:16:51 +0100 Lorenzo Bianconi wrote: > +static inline void > +xdp_features_set_redirect_target(xdp_features_t *xdp_features, bool support_sg) > +{ > + *xdp_features |= NETDEV_XDP_ACT_NDO_XMIT; > + if (support_sg) > + *xdp_features |= NETDEV_XDP_ACT_NDO_XMIT_SG; > +} > + > +static inline void > +xdp_features_clear_redirect_target(xdp_features_t *xdp_features) > +{ > + *xdp_features &= ~(NETDEV_XDP_ACT_NDO_XMIT | > + NETDEV_XDP_ACT_NDO_XMIT_SG); > +} > + Shouldn't these generate netlink notifications?