Em Thu, Jan 19, 2023 at 08:05:36AM -0800, Ian Rogers escreveu: > On Tue, Jan 10, 2023 at 2:20 PM Ian Rogers <irogers@xxxxxxxxxx> wrote: > > > > It is commonly useful to run a command using "/bin/sh -c" (like popen) > > and to place the output in a string. Move strbuf to libapi, add a new > > run_command that places output in a strbuf, then use it in help and > > llvm in perf. Some small strbuf efficiency improvements are > > included. Whilst adding a new function should increase lines-of-code, > > by sharing two similar usages in perf llvm and perf help, the overall > > lines-of-code is moderately reduced. > > > > First "perf llvm: Fix inadvertent file creation" is cherry-picked > > from: > > https://lore.kernel.org/lkml/20230105082609.344538-1-irogers@xxxxxxxxxx/ > > to avoid a merge conflict. The next patches deal with moving strbuf, > > adding the run_command function with Makefile dependency from > > libsubcmd to libapi, and improving the strbuf performance. The final > > two patches add usage from the perf command. > > > > Ian Rogers (7): > > perf llvm: Fix inadvertent file creation > > tools lib: Move strbuf to libapi > > tools lib subcmd: Add run_command_strbuf > > tools lib api: Minor strbuf_read improvements > > tools lib api: Tweak strbuf allocation size computation > > perf help: Use run_command_strbuf > > perf llvm: Remove read_from_pipe > > This isn't ready yet. Kernel test robot reported legitimate build > breakages in other tools outside of perf, I'm looking to address those > in separate patch series. > https://lore.kernel.org/lkml/20230116215751.633675-1-irogers@xxxxxxxxxx/ Thanks for the heads up, I recall seeing a build bot report. It's great to have that build bot testing perf patches, thanks to whoever put it in place! - Arnaldo
