On 1/17/23 7:52 PM, Thomas Weißschuh wrote:
The common layout for kbuild messages is as follows: - 2 spaces - 7 or more characters for the action - 1 space - name of the file being built/generated The custom message formatting included an additional space in the action part, which leads to misalignments with the rest of kbuild.
Could you give an example to show the output before/after the patch, and how it leads to mis-alignment and why it is a problem?
Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx> --- tools/testing/selftests/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index c22c43bbee19..5190c19295d4 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -98,7 +98,7 @@ Q = msg = else Q = @ -msg = @printf ' %-8s%s %s%s\n' "$(1)" "$(if $(2), [$(2)])" "$(notdir $(3))" "$(if $(4), $(4))"; +msg = @printf ' %-7s%s %s%s\n' "$(1)" "$(if $(2), [$(2)])" "$(notdir $(3))" "$(if $(4), $(4))"; MAKEFLAGS += --no-print-directory submake_extras := feature_display=0 endif
