On Sun, Jan 8, 2023 at 3:14 AM Martin Rodriguez Reboredo
<yakoyoku@xxxxxxxxx> wrote:
>
> Version 1.24 of pahole has the capability to exclude compilation units
It would be nice to have a reference ("...of pahole [1][2]") to the
commits that introduced it in `pahole` -- especially the second one
below has a nice commit message about the use case for this patch:
Link: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=49358dfe2aaae4e90b072332c3e324019826783f
[1]
Link: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=8ee363790b7437283c53090a85a9fec2f0b0fbc4
[2]
> (CUs) of specific languages. Rust, as of writing, is not currently
> supported by pahole and if it's used with a build that has BTF debugging
> enabled it results in malformed kernel and module binaries (see
> Rust-for-Linux/linux#735). So it's better for pahole to exclude Rust
I think this came from a rendered link from GitHub, so please
transform it into a link since otherwise people may be confused where
to find it:
Link: https://github.com/Rust-for-Linux/linux/issues/735 [3]
> Reviewed-by: Eric Curtin <ecurtin@xxxxxxxxxx>
> Tested-by: Eric Curtin <ecurtin@xxxxxxxxxx>
> Reviewed-by: Neal Gompa <neal@xxxxxxxxx>
> Tested-by: Neal Gompa <neal@xxxxxxxxx>
Given the patch has had non-trivial changes (in fact, in this case, it
fundamentally changed the implementation), these tags should be
removed and requested again.
Thanks for this!
Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
Cheers,
Miguel
