On 1/6/23 1:11 PM, Quentin Monnet wrote:
2023-01-06 12:40 UTC+0100 ~ Michal Suchanek <msuchanek@xxxxxxx>+ make -j48 -s -C /dev/shm/kbuild/linux.33946/current ARCH=powerpc HOSTCC=gcc CROSS_COMPILE=powerpc64-suse-linux- clean TypeError: '_sre.SRE_Match' object is not subscriptable Fixes: 8a76145a2ec2 ("bpf: explicitly define BPF_FUNC_xxx integer values") Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx> --- scripts/bpf_doc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/bpf_doc.py b/scripts/bpf_doc.py index e8d90829f23e..38d51e05c7a2 100755 --- a/scripts/bpf_doc.py +++ b/scripts/bpf_doc.py @@ -271,7 +271,7 @@ class HeaderParser(object): if capture: fn_defines_str += self.line helper_name = capture.expand(r'bpf_\1') - self.helper_enum_vals[helper_name] = int(capture[2]) + self.helper_enum_vals[helper_name] = int(capture.group(2)) self.helper_enum_pos[helper_name] = i i += 1 else:Thanks, the change looks good. Acked-by: Quentin Monnet <quentin@xxxxxxxxxxxxx> Would be nice to have a bit more context in the commit log: As I understand, Match objects have been scriptable since Python 3.6 (2016). Reference: https://docs.python.org/3/whatsnew/3.6.html#re
Agree, Michal, could you improve the commit description as it's a bit terse as-is and then resubmit your patch. Thanks, Daniel
