On Thu, Jan 5, 2023 at 4:41 PM Martin KaFai Lau <martin.lau@xxxxxxxxx> wrote: > > On 1/4/23 1:59 PM, Stanislav Fomichev wrote: > > @@ -199,12 +197,12 @@ int bpf_prog_offload_init(struct bpf_prog *prog, union bpf_attr *attr) > > attr->prog_type != BPF_PROG_TYPE_XDP) > > return -EINVAL; > > > > - if (attr->prog_flags) > > + if (attr->prog_flags & ~BPF_F_XDP_DEV_BOUND_ONLY) > > return -EINVAL; > > > > - offload = kzalloc(sizeof(*offload), GFP_USER); > > The kzalloc is still needed. Although a latter patch added it bad, it is better > not to miss it in the first place. Oh, good catch, probably lost during reshuffling some changes around, will undo. > > - if (!offload) > > - return -ENOMEM; > > + if (attr->prog_type == BPF_PROG_TYPE_SCHED_CLS && > > + attr->prog_flags & BPF_F_XDP_DEV_BOUND_ONLY) > > + return -EINVAL; > > > > offload->prog = prog; > > >
