Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state
From: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>
Date: Wed, 14 Dec 2022 13:33:58 +0100
Cc: david.keisarschm@xxxxxxxxxxxxxxx, Vignesh Raghavendra <vigneshr@xxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Song Liu <song@xxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, linux-mtd@xxxxxxxxxxxxxxxxxxx, Stanislav Fomichev <sdf@xxxxxxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Roman Gushchin <roman.gushchin@xxxxxxxxx>, Christoph Lameter <cl@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, x86@xxxxxxxxxx, John Fastabend <john.fastabend@xxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, ilay.bahat1@xxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, Yonghong Song <yhs@xxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, Petr Mladek <pmladek@xxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-mm@xxxxxxxxx, netdev@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Pekka Enberg <penberg@xxxxxxxxxx>, Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>, aksecurity@xxxxxxxxx, Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <Y5c8KLzJFz/XZMiM@zx2c4.com>

On Mon, Dec 12, 2022 at 03:35:20PM +0100, Jason A. Donenfeld wrote:
> Please CC me on future revisions.
> 
> As of 6.2, the prandom namespace is *only* for predictable randomness.
> There's no need to rename anything. So nack on this patch 1/5.

It is not obvious (for casual developers like me) that p in prandom
stands for predictable. Some renaming would be useful IMHO.

Regards
Stanislaw

Follow-Ups:
- Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state
  - From: Eric Dumazet

References:
- [PATCH 0/5] Replace invocations of prandom_u32 with get_random_u32
  - From: david . keisarschm
- [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state
  - From: david . keisarschm
- Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state
  - From: Jason A. Donenfeld

Prev by Date: Re: [RFC PATCH bpf-next 9/9] bpf: Use active vm to account bpf map memory usage
Next by Date: [PATCH bpf] bpf: Synchronize dispatcher update with bpf_dispatcher_xdp_func
Previous by thread: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state
Next by thread: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]