On Wed, Dec 7, 2022 at 8:26 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Mon, 5 Dec 2022 18:45:43 -0800 Stanislav Fomichev wrote: > > +- ``bpf_xdp_metadata_rx_timestamp_supported`` returns true/false to > > + indicate whether the device supports RX timestamps > > +- ``bpf_xdp_metadata_rx_timestamp`` returns packet RX timestamp > > +- ``bpf_xdp_metadata_rx_hash_supported`` returns true/false to > > + indicate whether the device supports RX hash > > +- ``bpf_xdp_metadata_rx_hash`` returns packet RX hash > > Would you mind pointing to the discussion about the separate > _supported() kfuncs? I recall folks had concerns about the function > call overhead, and now we have 2 calls per field? :S Take a look at [0] and [1]. I'm still assuming that we might support some restricted set of kfuncs that can be unrolled so keeping this simple/separate apis. 0: https://lore.kernel.org/bpf/CAADnVQJMvPjXCtKNH+WCryPmukgbWTrJyHqxrnO=2YraZEukPg@xxxxxxxxxxxxxx 1: https://lore.kernel.org/bpf/Y4XZkZJHVvLgTIk9@lavr/
