On Wed, 7 Dec 2022 16:02:13 -0800 Kees Cook wrote: > Is this what you had in mind for this kind of change? nice, thanks a lot! the only thing left to do is kdoc updates: - the existing kdocs should no longer mention frag_size == 0 - kdoc on the slab_build_skb() should say: /* build_skb() variant which can operate on slab buffers. * Note that this should be used sparingly as slab buffers * cannot be combined efficiently by GRO! */ But this can all be done by us in a follow up, there's probably more cleaning we can do in those kdocs. > v2: introduce separate helper (kuba) > v1: https://lore.kernel.org/netdev/20221206231659.never.929-kees@xxxxxxxxxx/
