On Wed, Dec 07, 2022 at 12:55:31PM -0800, Joanne Koong wrote: > This patchset is the 3rd in the dynptr series. The 1st can be found here [0] > and the 2nd can be found here [1]. > > In this patchset, the following convenience helpers are added for interacting > with bpf dynamic pointers: > > * bpf_dynptr_data_rdonly > * bpf_dynptr_trim > * bpf_dynptr_advance > * bpf_dynptr_is_null > * bpf_dynptr_is_rdonly > * bpf_dynptr_get_size > * bpf_dynptr_get_offset > * bpf_dynptr_clone > * bpf_dynptr_iterator This is great, but it really stretches uapi limits. Please convert the above and those in [1] to kfuncs. I know that there can be an argument made for consistency with existing dynptr uapi helpers, but we got burned on them once and scrambled to add 'flags' argument. kfuncs are unstable and can be adjusted/removed at any time later. The verifier now supports dynptr in kfunc verification, so conversion should be straightforward. Thanks > > Please note that this patchset will be rebased on top of dynptr refactoring/fixes > once that is landed upstream. > > [0] https://lore.kernel.org/bpf/20220523210712.3641569-1-joannelkoong@xxxxxxxxx/ > [1] https://lore.kernel.org/bpf/20221021011510.1890852-1-joannelkoong@xxxxxxxxx/ >
