On Tue, 2022-12-06 at 19:21 -0500, Paul Moore wrote: > On Mon, Nov 28, 2022 at 9:43 AM Roberto Sassu > <roberto.sassu@xxxxxxxxxxxxxxx> wrote: > > From: Roberto Sassu <roberto.sassu@xxxxxxxxxx> > > > > Ensure that for non-void LSM hooks there is a description of the return > > values. > > > > Also, replace spaces with tab for indentation, remove empty lines between > > the hook description and the list of parameters, adjust semicolons and add > > the period at the end of the parameter description. > > > > Finally, move the description of gfp parameter of the > > xfrm_policy_alloc_security hook together with the others. > > > > Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx> > > --- > > include/linux/lsm_hooks.h | 221 ++++++++++++++++++++++++-------------- > > 1 file changed, 138 insertions(+), 83 deletions(-) > > Thanks Roberto, I've merged this into lsm/next with one small tweak (below). > > > diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h > > index c35e260efd8c..6502a1bea93a 100644 > > --- a/include/linux/lsm_hooks.h > > +++ b/include/linux/lsm_hooks.h > > @@ -677,7 +695,7 @@ > > * indicates which of the set*uid system calls invoked this hook. If > > * @new is the set of credentials that will be installed. Modifications > > * should be made to this rather than to @current->cred. > > - * @old is the set of credentials that are being replaces > > + * @old is the set of credentials that are being replaces. > > Might as well change "replaces" to "replaced". I'll go ahead and fix > that up during the merge. Thanks a lot! Roberto