On Mon, Dec 05, 2022 at 06:45:45PM -0800, Stanislav Fomichev wrote:
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index fc4e313a4d2e..00951a59ee26 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -15323,6 +15323,24 @@ static int fixup_kfunc_call(struct bpf_verifier_env *env, struct bpf_insn *insn,
> return -EINVAL;
> }
>
> + *cnt = 0;
> +
> + if (resolve_prog_type(env->prog) == BPF_PROG_TYPE_XDP) {
> + if (bpf_prog_is_offloaded(env->prog->aux)) {
> + verbose(env, "no metadata kfuncs offload\n");
> + return -EINVAL;
> + }
If I'm reading this correctly than this error will trigger
for any XDP prog trying to use a kfunc?
I was hoping that BPF CI can prove my point, but it failed to
build your newly added xdp_hw_metadata.c test.
