On Mon, Nov 21, 2022 at 07:52:12AM -0700, Song Liu wrote: > On Sun, Nov 20, 2022 at 3:41 AM Mike Rapoport <rppt@xxxxxxxxxx> wrote: > > > > > > > > The most obvious one to implement Peter's suggestion with VM_TOPDOWN_VMAP > > > > so that execmem_alloc() can be actually used by modules. > > > > > > Current implementation is an alternative to VM_TOPDOWN_VMAP. I am > > > very sure it works for modules just like VM_TOPDOWN_VMAP solution. > > > > It might, but it still does not. And until they do I consider these > > patches as an optimization for BFP rather than unification of code > > allocations. > > We haven't got module to use execmem_alloc yet, that's true. But > this has nothing to do with VM_TOPDOWN_VMAP at all. The point is that Peter suggested a way to make module_alloc() use 2M pages, so that all code allocations could benefit from it. Your execmem_alloc() isn't anywhere near this. > Thanks, > Song -- Sincerely yours, Mike.
