On Mon, Nov 21, 2022 at 09:29:20AM -0700, Song Liu wrote: > On Mon, Nov 21, 2022 at 8:55 AM Christoph Hellwig <hch@xxxxxx> wrote: > > > > On Mon, Nov 21, 2022 at 04:52:24PM +0100, Daniel Borkmann wrote: > > >> +void *execmem_fill(void *dst, void *src, size_t len) > > >> +{ > > >> + return ERR_PTR(-EOPNOTSUPP); > > >> +} > > > > > > Don't they need EXPORT_SYMBOL_GPL, too? > > > > None of these should be exported. Modular code has absolutely no > > business creating executable mappings. > > I added these exports for test_vmalloc.ko. Is there a way to only export > them to test_vmalloc.ko but nothing else? See EXPORT_SYMBOL_NS_GPL() Luis