On Wed, Nov 16, 2022 at 7:48 AM Roberto Sassu
<roberto.sassu@xxxxxxxxxxxxxxx> wrote:
> +static bool is_ret_value_allowed(int ret, u32 ret_flags)
> +{
> + if ((ret < 0 && !(ret_flags & LSM_RET_NEG)) ||
> + (ret == 0 && !(ret_flags & LSM_RET_ZERO)) ||
> + (ret == 1 && !(ret_flags & LSM_RET_ONE)) ||
> + (ret > 1 && !(ret_flags & LSM_RET_GT_ONE)))
> + return false;
> +
> + return true;
> +}
> +
> /* For every LSM hook that allows attachment of BPF programs, declare a nop
> * function where a BPF program can be attached.
> */
> @@ -30,6 +41,15 @@ noinline RET bpf_lsm_##NAME(__VA_ARGS__) \
> #include <linux/lsm_hook_defs.h>
> #undef LSM_HOOK
>
> +#define LSM_HOOK(RET, DEFAULT, RET_FLAGS, NAME, ...) \
> +noinline RET bpf_lsm_##NAME##_ret(int ret) \
> +{ \
> + return is_ret_value_allowed(ret, RET_FLAGS) ? ret : DEFAULT; \
> +}
> +
> +#include <linux/lsm_hook_defs.h>
> +#undef LSM_HOOK
> +
because lsm hooks is mess of undocumented return values your
"solution" is to add hundreds of noninline functions
and hack the call into them in JITs ?!
That's an obvious no-go. Not sure why you bothered to implement it.
