Re: [PATCH bpf-next v2 0/5] clean-up bpftool from legacy support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/09/ , Yonghong Song wrote:
>
>
> On 11/8/22 11:44 PM, Sahid Orentino Ferdjaoui wrote:
> > As part of commit 93b8952d223a ("libbpf: deprecate legacy BPF map
> > definitions") and commit bd054102a8c7 ("libbpf: enforce strict libbpf
> > 1.0 behaviors") The --legacy option is not relevant anymore. #1 is
> > removing it. #4 is cleaning the code from using libbpf_get_error().
> >
> > About patches #2 and #3 They are changes discovered while working on
> > this series (credits to Quentin Monnet). #2 is cleaning-up usage of an
> > unnecessary PTR_ERR(NULL), finally #3 is fixing an invalid value
> > passed to strerror().
> >
> > v1 -> v2:
> >    - Addressed review comments from Yonghong Song on patch #4
> >    - Added a patch #5 that removes unwanted function noticed by
> >      Yonghong Song
> >
> > Sahid Orentino Ferdjaoui (5):
> >    bpftool: remove support of --legacy option for bpftool
> >    bpftool: replace return value PTR_ERR(NULL) with 0
> >    bpftool: fix error message when function can't register struct_ops
> >    bpftool: clean-up usage of libbpf_get_error()
> >    bpftool: remove function free_btf_vmlinux()
> >
> >   .../bpftool/Documentation/common_options.rst  |  9 --------
> >   .../bpftool/Documentation/substitutions.rst   |  2 +-
> >   tools/bpf/bpftool/bash-completion/bpftool     |  2 +-
> >   tools/bpf/bpftool/btf.c                       | 17 ++++++--------
> >   tools/bpf/bpftool/btf_dumper.c                |  2 +-
> >   tools/bpf/bpftool/gen.c                       | 11 ++++------
> >   tools/bpf/bpftool/iter.c                      |  6 ++---
> >   tools/bpf/bpftool/main.c                      | 22 +++----------------
> >   tools/bpf/bpftool/main.h                      |  3 +--
> >   tools/bpf/bpftool/map.c                       | 20 ++++++-----------
> >   tools/bpf/bpftool/prog.c                      | 15 +++++--------
> >   tools/bpf/bpftool/struct_ops.c                | 22 ++++++++-----------
> >   .../selftests/bpf/test_bpftool_synctypes.py   |  6 ++---
> >   13 files changed, 44 insertions(+), 93 deletions(-)
> >
> > --
> > 2.34.1
> >
>
> You can carry the 'Ack' if no significant change for
> each patch.

Thanks a lot for this advice. I will use this in my v3 when addressing
Andrii comments.

> Ack for the whole series.
>
> Acked-by: Yonghong Song <yhs@xxxxxx>





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux