Re: [PATCH bpf-next v3 2/3] selftests/bpf: Dump data sections as part of btf_dump_test_case tests

[Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx>]

On Thu, Nov 10, 2022 at 6:43 AM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote:
>
> Modify `test_btf_dump_case` to test `btf_dump__dump_type_data`
> alongside `btf_dump__dump_type`.
>
> The `test_btf_dump_case` function provides a convenient way to test
> `btf_dump__dump_type` behavior as test cases are specified in separate
> C files and any differences are reported using `diff` utility. This
> commit extends `test_btf_dump_case` to call `btf_dump__dump_type_data`
> for each `BTF_KIND_DATASEC` object in the test case object file.
>
> Signed-off-by: Eduard Zingerman <eddyz87@xxxxxxxxx>
> ---

please use ASSERT_xxx() instead of CHECK()

>  .../selftests/bpf/prog_tests/btf_dump.c       | 118 +++++++++++++++---
>  1 file changed, 104 insertions(+), 14 deletions(-)
>

[...]