Re: [PATCH bpf-next v8 1/1] doc: DEVMAPs and XDP_REDIRECT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 10, 2022 at 11:08:18AM -0500, mtahhan@xxxxxxxxxx wrote:
> From: Maryam Tahhan <mtahhan@xxxxxxxxxx>
> 
> Add documentation for BPF_MAP_TYPE_DEVMAP and
> BPF_MAP_TYPE_DEVMAP_HASH including kernel version
> introduced, usage and examples.
> 
> Add documentation that describes XDP_REDIRECT.

Shouldn't two documentations be separated into its own patch (thus
creating 2-patch series)?

 
> +XDP_REDIRECT works with the following map types:
> +
><snipped>...
> +Silent packet drops for ``XDP_REDIRECT`` can be debugged using:
> +
> +- bpf_trace
> +- perf_record

XDP_REDIRECT is inline-quoted here, but plain on other places. I would
like to keep that above plain instead.

What about below instead?

```
Silent packet drops for ``XDP_REDIRECT`` can be debugged using either
bpf_trace tool or ``perf record`` command.
```

Otherwise LGTM.

-- 
An old man doll... just what I always wanted! - Clara

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux