Yonghong Song wrote: > > > On 11/9/22 10:40 AM, Domenico Cerasuolo wrote: > > From: Domenico Cerasuolo <dceras@xxxxxxxx> > > > > When showing the result of a test group, if one > > of the subtests was skipped, while still having > > passing subtests, the group result was marked as > > SKIP. E.g.: > > > > 223/1 usdt/basic:SKIP > > 223/2 usdt/multispec:OK > > 223/3 usdt/urand_auto_attach:OK > > 223/4 usdt/urand_pid_attach:OK > > 223 usdt:SKIP > > > > The test result of usdt in the example above > > should be OK instead of SKIP, because the test > > group did have passing tests and it would be > > considered in "normal" state. > > > > With this change, only if all of the subtests > > were skipped, the group test is marked as SKIP. > > When only some of the subtests are skipped, a > > more detailed result is given, stating how > > many of the subtests were skipped. E.g: > > > > 223/1 usdt/basic:SKIP > > 223/2 usdt/multispec:OK > > 223/3 usdt/urand_auto_attach:OK > > 223/4 usdt/urand_pid_attach:OK > > 223 usdt:OK (SKIP: 1/4) > > > > changes from v1: > > - added (SKIP: x/y) to OK tests that have > > SKIP subtests > > - merged print_test_name and test_result > > functions as they were always called together > > > > Signed-off-by: Domenico Cerasuolo <dceras@xxxxxxxx> > > Acked-by: Yonghong Song <yhs@xxxxxx> Late but Ack from me as well this resolves my original comment. Thanks! Acked-by: John Fastabend <john.fastabend@xxxxxxxxx>
