mtahhan@xxxxxxxxxx writes: > From: Maryam Tahhan <mtahhan@xxxxxxxxxx> > > Add documentation for BPF_MAP_TYPE_DEVMAP and > BPF_MAP_TYPE_DEVMAP_HASH including kernel version > introduced, usage and examples. > > Add documentation that describes XDP_REDIRECT. > > Signed-off-by: Maryam Tahhan <mtahhan@xxxxxxxxxx> Just re-read this, and I think it's much improved over previous versions - nice work! With just one nit below, feel free to re-add my: Reviewed-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> [...] > +With ``BPF_F_BROADCAST`` the packet will be broadcast to all the interfaces > +in the map, with ``BPF_F_EXCLUDE_INGRESS`` the ingress interface will be excluded > +from the broadcast. > + > +.. note:: > + - The key is ignored if BPF_F_BROADCAST is set. > + - Multicast can also be achieved using multiple DEVMAPs. That last bullet was a bit confusing on a first read. Maybe change it to: - The broadcast feature can also be used to implement multicast forwarding: simply create multiple DEVMAPs, each one corresponding to a single multicast group. -Toke
