David Ahern <dsahern@xxxxxxxxx> writes: > On 11/1/22 6:52 AM, Toke Høiland-Jørgensen wrote: >> Stanislav Fomichev <sdf@xxxxxxxxxx> writes: >> >>> On Mon, Oct 31, 2022 at 3:57 PM Martin KaFai Lau <martin.lau@xxxxxxxxx> wrote: >>>> >>>> On 10/31/22 10:00 AM, Stanislav Fomichev wrote: >>>>>> 2. AF_XDP programs won't be able to access the metadata without using a >>>>>> custom XDP program that calls the kfuncs and puts the data into the >>>>>> metadata area. We could solve this with some code in libxdp, though; if >>>>>> this code can be made generic enough (so it just dumps the available >>>>>> metadata functions from the running kernel at load time), it may be >>>>>> possible to make it generic enough that it will be forward-compatible >>>>>> with new versions of the kernel that add new fields, which should >>>>>> alleviate Florian's concern about keeping things in sync. >>>>> >>>>> Good point. I had to convert to a custom program to use the kfuncs :-( >>>>> But your suggestion sounds good; maybe libxdp can accept some extra >>>>> info about at which offset the user would like to place the metadata >>>>> and the library can generate the required bytecode? >>>>> >>>>>> 3. It will make it harder to consume the metadata when building SKBs. I >>>>>> think the CPUMAP and veth use cases are also quite important, and that >>>>>> we want metadata to be available for building SKBs in this path. Maybe >>>>>> this can be resolved by having a convenient kfunc for this that can be >>>>>> used for programs doing such redirects. E.g., you could just call >>>>>> xdp_copy_metadata_for_skb() before doing the bpf_redirect, and that >>>>>> would recursively expand into all the kfunc calls needed to extract the >>>>>> metadata supported by the SKB path? >>>>> >>>>> So this xdp_copy_metadata_for_skb will create a metadata layout that >>>> >>>> Can the xdp_copy_metadata_for_skb be written as a bpf prog itself? >>>> Not sure where is the best point to specify this prog though. Somehow during >>>> bpf_xdp_redirect_map? >>>> or this prog belongs to the target cpumap and the xdp prog redirecting to this >>>> cpumap has to write the meta layout in a way that the cpumap is expecting? >>> >>> We're probably interested in triggering it from the places where xdp >>> frames can eventually be converted into skbs? >>> So for plain 'return XDP_PASS' and things like bpf_redirect/etc? (IOW, >>> anything that's not XDP_DROP / AF_XDP redirect). >>> We can probably make it magically work, and can generate >>> kernel-digestible metadata whenever data == data_meta, but the >>> question - should we? >>> (need to make sure we won't regress any existing cases that are not >>> relying on the metadata) >> >> So I was thinking about whether we could have the kernel do this >> automatically, and concluded that this was probably not feasible in >> general, which is why I suggested the explicit helper. My reasoning was >> as follows: >> >> For straight XDP_PASS in the driver we don't actually need to do >> anything today, as the driver itself will build the SKB and read any >> metadata it needs from the HW descriptor[0]. > > The program can pop encap headers, mpls tags, ... and thus affect the > metadata in the descriptor (besides the timestamp). Hmm, right, good point. How does XDP_PASS deal with that today, though? I guess this is an argument for making the "read HW metadata into SKB format" thing be a kfunc/helper rather than a flag to bpf_redirect(), then. Because then we can allow the XDP program to override/modify the metadata afterwards, either by defining it as: int xdp_copy_metadata_for_skb(struct xdp_md *ctx, struct xdp_skb_meta *override, int flags) where the XDP program can fill in 'override' with new data that takes precedence over the stuff from the HW (like a modified checksum or offset or something). Or we can just have xdp_copy_metadata_for_skb() into the regular XDP metadata area, and let the XDP program modify it afterwards. I feel like the override argument would be easier to use, though. Also, having it be completely opaque *where* the metadata is stored when using xdp_copy_metadata_for_skb() lets us be more flexible about it. E.g., the helper could write the timestamp directly into skb_shared_info, instead of stuffing it into the metadata area where it then has to be copied out later. >> This leaves packets that are redirected (either to a veth or a cpumap so >> we build SKBs from them later); here the problem is that we buffer the >> packets (for performance reasons) so that the redirect doesn't actually >> happen until after the driver exits the NAPI loop. At which point we >> don't have access to the HW descriptors anymore, so we can't actually >> read the metadata. >> >> This means that if we want to execute the metadata gathering >> automatically, we'd have to do it in xdp_do_redirect(). Which means that >> we'll have to figure out, at that point, whether the XDP frame is likely >> to be converted to an SKB. This will add at least one branch (and >> probably more) that will be in-path for every redirected frame. > > or forwarded to a tun device as an xdp frame and wanting to pass > metadata into a VM which may construct an skb in the guest. This case is > arguably aligned with the redirect from vendor1 to vendor2. > > This thread (and others) seem to be focused on the Rx path, but the Tx > path is equally important with similar needs. You're right, of course. Thinking a bit out loud here, but I actually think the kfunc approach makes the TX side easier: We already have to ability to execute a second "TX" XDP program inside the devmaps. At which point that program is also tied to a particular interface. So we could duplicate the RX-side kfunc trick, and expose a set of *writer* kfuncs for metadata. So that an XDP program in the devmap can simply do: if (bpf_xdp_metadata_tx_timestamp_supported()) bpf_xdp_metadata_tx_timestamp(ctx, tsval); and those two kfuncs will be unrolled by the TX-side driver as well to store them wherever they need to go to reach the wire. The one complication here being, of course, that by the time the devmap XDP program is executed, the driver hasn't seen the frame at all, yet, so it doesn't have anywhere to store that data. We'd need to reuse the frame metadata area for this (with some flag indicating that it's valid), or we'd need a new area the driver could use as scratch space specific to the xdp_frame (like the skb->cb field, I suppose). -Toke
