Re: [PATCH v3] evm: Correct inode_init_security hooks behaviors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Nicolas,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on zohar-integrity/next-integrity]
[also build test WARNING on linus/master v6.1-rc2 next-20221025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nicolas-Bouchinet/evm-Correct-inode_init_security-hooks-behaviors/20221025-221337
base:   https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity
patch link:    https://lore.kernel.org/r/Y1fu4jofqLHVDprT%40archlinux
patch subject: [PATCH v3] evm: Correct inode_init_security hooks behaviors
config: m68k-allyesconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/acbbdcb851ed7cd1894efad182f0325db04b9e5a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nicolas-Bouchinet/evm-Correct-inode_init_security-hooks-behaviors/20221025-221337
        git checkout acbbdcb851ed7cd1894efad182f0325db04b9e5a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash security/integrity/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> security/integrity/evm/evm_main.c:310:5: warning: no previous prototype for 'evm_protected_xattr' [-Wmissing-prototypes]
     310 | int evm_protected_xattr(const char *req_xattr_name)
         |     ^~~~~~~~~~~~~~~~~~~


vim +/evm_protected_xattr +310 security/integrity/evm/evm_main.c

   309	
 > 310	int evm_protected_xattr(const char *req_xattr_name)
   311	{
   312		return evm_protected_xattr_common(req_xattr_name, false);
   313	}
   314	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux