On Tue, Oct 18, 2022 at 07:29:16PM +0530, Kumar Kartikeya Dwivedi wrote: > The original support for bpf_user_ringbuf_drain callbacks simply > short-circuited checks for the dynptr state, allowing users to pass > PTR_TO_DYNPTR (now CONST_PTR_TO_DYNPTR) to helpers that initialize a > dynptr. This bug would have also surfaced with other dynptr helpers in > the future that changed dynptr view or modified it in some way. > > Include test cases for all cases, i.e. both bpf_dynptr_from_mem and > bpf_ringbuf_reserve_dynptr, and ensure verifier rejects both of them. > Without the fix, both of these programs load and pass verification. > > Signed-off-by: Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx> > --- LGTM Acked-by: David Vernet <void@xxxxxxxxxxxxx>
