On Fri, Oct 7, 2022 at 8:31 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> On Fri, Oct 07, 2022 at 11:45:36AM +0200, Jiri Olsa wrote:
> > On Fri, Oct 07, 2022 at 10:13:27AM +0200, Sumanth Korikkar wrote:
> > > * Raw data is also filled by bpf_perf_event_output.
> > > * Add sample_flags to indicate raw data.
> > > * This eliminates the segfaults as shown below:
> > > Run ./samples/bpf/trace_output
> > > BUG pid 9 cookie 1001000000004 sized 4
> > > BUG pid 9 cookie 1001000000004 sized 4
> > > BUG pid 9 cookie 1001000000004 sized 4
> > > Segmentation fault (core dumped)
> > >
> > > Fixes: 838d9bb62d13 ("perf: Use sample_flags for raw_data")
> > > Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> > > Signed-off-by: Sumanth Korikkar <sumanthk@xxxxxxxxxxxxx>
> >
> > Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> >
> > Peter,
> > I think this should go through your tree again?
> > bpf-next/master does not have sample_flags merged yet
>
> Yep can do. I'll line it up in perf/urgent (Ingo just send out
> perf/core).
Peter,
Could you please hurry up. 11 days have passed.
This issue affects everyone the hard way now after merging
all the trees: tip -> linus -> net-next -> bpf-next.
The BPF CI is red right now with 5 tests failing because
this fix is still missing.
It's causing a headache to maintainers and developers.
