On Mon, Oct 17, 2022 at 4:16 PM Dave Thaler <dthaler@xxxxxxxxxxxxx> wrote: > > > -----Original Message----- > > From: Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> > > Sent: Monday, October 17, 2022 2:41 PM > > To: Dave Thaler <dthaler@xxxxxxxxxxxxx> > > Cc: bpf@xxxxxxxxxxxxxxx; dthaler1968@xxxxxxxxxxxxxx > > Subject: Re: [PATCH 1/9] bpf, docs: Add note about type convention > > > > On Mon, Oct 17, 2022 at 08:42:13PM +0000, Dave Thaler wrote: > > > Just checking if there is any more feedback on this patch set, as I've > > > seen no comments since this set was posted on October 4th which > > > addresses comments received on the previous submission. > > > > The was an issue found by build bot... > > > > > Let me know if I'm missing some step I should be doing as I'm new to > > > this submission process. > > > > I'm still not excited about 'appendix'. How about moving it into separate file? > > instruction-set-opcodes.rst ? > > > > If folks really want to use it in automated way that table needs to be uniform > > and shouldn't be interleaved with normal text. > > That's why a separate file with just that table seems a better fit. > > I can move it to a separate file, but that appendix is added in patch 5/9 of this set. > Any comments on patches 1-4 or are they all good now? Don't know. Since they're not in patchwork anymore no one is looking at them. Just resend.
