On Mon, Oct 10, 2022 at 5:11 PM Tejun Heo <tj@xxxxxxxxxx> wrote: > > On Mon, Oct 10, 2022 at 11:58:44PM +0000, Yosry Ahmed wrote: > > Add cgroup_all_get_from_fd() and cgroup_all_get_from_file() that > > support both cgroup1 and cgroup2. > > Looks generally good. How about cgroup_v1v2_ as the prefix? Thanks for taking a look. I don't have a strong opinion here. I picked cgroup_all_* vs cgroup12_* or cgroup_v1v2_* because it's easier on the eyes. My preference would have been to rename the old versions to cgroup_dfl_* instead, but like you said this might confuse existing users. Anyway, I am fine with whatever you choose. Let me know if you need me to send a v2 for changing the prefix. > > Thanks. > > -- > tejun