Re: [PATCH v2 bpf-next 2/2] scripts/bpf_doc.py: update logic to not assume sequential enum values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2022-10-06 05:24:52 GMT+0100 ~ Andrii Nakryiko <andrii@xxxxxxxxxx>
> Relax bpf_doc.py's expectation of all BPF_FUNC_xxx enumerators having
> sequential values increasing by one. Instead, only make sure that
> relative order of BPF helper descriptions in comments matches
> enumerators definitions order.
> 
> Also additionally make sure that helper IDs are not duplicated.
> 
> And also make sure that for cases when we have multiple descriptions for
> the same BPF helper (e.g., for bpf_get_socket_cookie()), all such
> descriptions are grouped together.
> 
> Such checks should capture all the same (and more) issues in upstream
> UAPI headers, but also handle backported kernels correctly.
> 
> Reported-by: Alexei Starovoitov <ast@xxxxxxxxxx>
> Signed-off-by: Andrii Nakryiko <andrii@xxxxxxxxxx>

The changes look good to me, all checks seem to work as described on my
setup. Nice to validate that multiple descriptions for a helper come
together. Thanks!

Reviewed-by: Quentin Monnet <quentin@xxxxxxxxxxxxx>




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux