Hi Hao, On Thu, Sep 22, 2022 at 12:36 PM Hao Luo <haoluo@xxxxxxxxxx> wrote: > > On Wed, Sep 21, 2022 at 9:40 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote: > > > > The perf_event_cgrp_id can be different on other configurations. > > To be more portable as CO-RE, it needs to get the cgroup subsys id > > using the bpf_core_enum_value() helper. > > > > I remember using bpf_core_enum_value requires a compiler built-in. So > the build will fail on old compiler such as clang-11. See [1]. Maybe > we should surround it with #if > __has_builtin(__builtin_preserve_enum_value) to be sure. > > [1] https://www.spinics.net/lists/bpf/msg30859.html Thanks for pointing this out. As this is a kind of optimization I think we can fallback to using the existing value if not available. Will send v3. Thanks, Namhyung
