On 9/18/22 8:57 PM, Hou Tao wrote:
From: Hou Tao <houtao1@xxxxxxxxxx>
Add test result message when test_task_storage_map_stress_lookup()
succeeds or is skipped. The test case can be skipped due to the choose
of preemption model in kernel config, so export skips in test_maps.c and
increase it when needed.
The following is the output of test_maps when the test case succeeds or
is skipped:
test_task_storage_map_stress_lookup:PASS
test_maps: OK, 0 SKIPPED
test_task_storage_map_stress_lookup SKIP (no CONFIG_PREEMPT)
test_maps: OK, 1 SKIPPED
Signed-off-by: Hou Tao <houtao1@xxxxxxxxxx>
Applied with a Fixes tag,
Fixes: 73b97bc78b32 ("selftests/bpf: ......
Please remember to add it next time for fixes.
Also, ...
---
tools/testing/selftests/bpf/map_tests/task_storage_map.c | 6 +++++-
tools/testing/selftests/bpf/test_maps.c | 2 +-
tools/testing/selftests/bpf/test_maps.h | 2 ++
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/map_tests/task_storage_map.c b/tools/testing/selftests/bpf/map_tests/task_storage_map.c
index 1adc9c292eb2..aac08c85240b 100644
--- a/tools/testing/selftests/bpf/map_tests/task_storage_map.c
+++ b/tools/testing/selftests/bpf/map_tests/task_storage_map.c
@@ -77,8 +77,11 @@ void test_task_storage_map_stress_lookup(void)
CHECK(err, "open_and_load", "error %d\n", err);
/* Only for a fully preemptible kernel */
- if (!skel->kconfig->CONFIG_PREEMPT)
+ if (!skel->kconfig->CONFIG_PREEMPT) {
+ printf("%s SKIP (no CONFIG_PREEMPT)\n", __func__);
+ skips++;
I noticed it is missing a read_bpf_task_storage_busy__destroy() here.
Please fix.