On Mon, Sep 19, 2022 at 07:07:22PM +0800, shaozhengchao wrote: > > > On 2022/9/18 3:03, Cong Wang wrote: > > On Fri, Sep 16, 2022 at 04:51:54PM +0800, Zhengchao Shao wrote: > > > Helper macro for tcf_action that don't do anything special in module > > > and net init/exit. This eliminates a lot of boilerplate. Each module > > > may only use this macro once, and calling it replaces module/net_init() > > > and module/net_exit(). > > > > > > > This looks over engineering to me. I don't think this reduces any code > > size or help any readability. > > > > Thanks. > Hi Wang: > Thank you for your review. I think this macro can simplify > repeated code when adding action modules later. > I don't think so, it hides the actual code in a less readable way. I'd like to read the non-macro code. Thanks.
