On Fri, Sep 16, 2022 at 12:56 PM Victor Nogueira <victor@xxxxxxxxxxxx> wrote: > > > On 15/09/2022 23:02, Zhengchao Shao wrote: > > The walk implementation of most tc cls modules is basically the same. > > That is, the values of count and skip are checked first. If count is > > greater than or equal to skip, the registered fn function is executed. > > Otherwise, increase the value of count. So the code can be refactored. > > Then use helper function to replace the code of each cls module in > > alphabetical order. > > > > The walk function is invoked during dump. Therefore, test cases related > > to the tdc filter need to be added. > > > > Last, thanks to Jamal, Victor and Wang for their review. > > > > Add test cases locally and perform the test. The test results are listed > > below: > > > > Reviewed-by: Victor Nogueira <victor@xxxxxxxxxxxx> > Tested-by: Victor Nogueira <victor@xxxxxxxxxxxx> For the series: Acked-by: Jamal Hadi Salim <jhs@xxxxxxxxxxxx> cheers, jamal