On Wed, Sep 7, 2022 at 8:45 AM Tejun Heo <tj@xxxxxxxxxx> wrote: > > On Wed, Sep 07, 2022 at 05:43:31AM -1000, Tejun Heo wrote: > > Hello, > > > > On Fri, Sep 02, 2022 at 02:29:50AM +0000, Yafang Shao wrote: > > ... > > > This patchset tries to resolve the above two issues by introducing a > > > selectable memcg to limit the bpf memory. Currently we only allow to > > > select its ancestor to avoid breaking the memcg hierarchy further. > > > Possible use cases of the selectable memcg as follows, > > > > As discussed in the following thread, there are clear downsides to an > > interface which requires the users to specify the cgroups directly. > > > > https://lkml.kernel.org/r/YwNold0GMOappUxc@xxxxxxxxxxxxxxx > > > > So, I don't really think this is an interface we wanna go for. I was hoping > > to hear more from memcg folks in the above thread. Maybe ping them in that > > thread and continue there? > > Ah, another thing. If the memcg accounting is breaking things right now, we > can easily introduce a memcg disable flag for bpf memory. That should help > alleviating the immediate breakage while we figure this out. Hmm. We discussed this option already. We definitely don't want to introduce an uapi knob that will allow anyone to skip memcg accounting today and in the future.