Re: [PATCH bpf-next v4 0/8] bpf: Support struct argument for trampoline base progs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@xxxxxxxxxx>:

On Wed, 31 Aug 2022 08:26:41 -0700 you wrote:
> Currently struct arguments are not supported for trampoline based progs.
> One of major reason is that struct argument may pass by value which may
> use more than one registers. This breaks trampoline progs where
> each argument is assumed to take one register. bcc community reported the
> issue ([1]) where struct argument is not supported for fentry program.
>   typedef struct {
>         uid_t val;
>   } kuid_t;
>   typedef struct {
>         gid_t val;
>   } kgid_t;
>   int security_path_chown(struct path *path, kuid_t uid, kgid_t gid);
> Inside Meta, we also have a use case to attach to tcp_setsockopt()
>   typedef struct {
>         union {
>                 void            *kernel;
>                 void __user     *user;
>         };
>         bool            is_kernel : 1;
>   } sockptr_t;
>   int tcp_setsockopt(struct sock *sk, int level, int optname,
>                      sockptr_t optval, unsigned int optlen);
> 
> [...]

Here is the summary with links:
  - [bpf-next,v4,1/8] bpf: Allow struct argument in trampoline based programs
    https://git.kernel.org/bpf/bpf-next/c/720e6a435194
  - [bpf-next,v4,2/8] bpf: x86: Support in-register struct arguments in trampoline programs
    https://git.kernel.org/bpf/bpf-next/c/a9c5ad31fbdc
  - [bpf-next,v4,3/8] bpf: Update descriptions for helpers bpf_get_func_arg[_cnt]()
    https://git.kernel.org/bpf/bpf-next/c/27ed9353aec9
  - [bpf-next,v4,4/8] bpf: arm64: No support of struct argument in trampoline programs
    https://git.kernel.org/bpf/bpf-next/c/eb707dde264a
  - [bpf-next,v4,5/8] libbpf: Add new BPF_PROG2 macro
    https://git.kernel.org/bpf/bpf-next/c/34586d29f8df
  - [bpf-next,v4,6/8] selftests/bpf: Add struct argument tests with fentry/fexit programs.
    https://git.kernel.org/bpf/bpf-next/c/1642a3945e22
  - [bpf-next,v4,7/8] selftests/bpf: Use BPF_PROG2 for some fentry programs without struct arguments
    https://git.kernel.org/bpf/bpf-next/c/a7c2ca3a2f69
  - [bpf-next,v4,8/8] selftests/bpf: Add tracing_struct test in DENYLIST.s390x
    https://git.kernel.org/bpf/bpf-next/c/ae63c10fc241

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux