On Tue, Sep 6, 2022 at 6:44 AM Quentin Monnet <quentin@xxxxxxxxxxxxx> wrote: > [...] > > +# If one of the above feature combinations is set, we support libbfd > ifneq ($(filter -lbfd,$(LIBS)),) > -CFLAGS += -DHAVE_LIBBFD_SUPPORT > -SRCS += $(BFD_SRCS) > + CFLAGS += -DHAVE_LIBBFD_SUPPORT > + > + # Libbfd interface changed over time, figure out what we need > + ifeq ($(feature-disassembler-four-args), 1) > + CFLAGS += -DDISASM_FOUR_ARGS_SIGNATURE > + endif > + ifeq ($(feature-disassembler-init-styled), 1) > + CFLAGS += -DDISASM_INIT_STYLED > + endif > +endif > +ifeq ($(filter -DHAVE_LIBBFD_SUPPORT,$(CFLAGS)),) > + # No support for JIT disassembly > + SRCS := $(filter-out jit_disasm.c,$(SRCS)) > endif This part could just be an else clause for the ifneq above. Well, I guess the difference is minimal. Acked-by: Song Liu <song@xxxxxxxxxx> > > HOST_CFLAGS = $(subst -I$(LIBBPF_INCLUDE),-I$(LIBBPF_BOOTSTRAP_INCLUDE),\ > -- > 2.34.1 >
