On Tue, Sep 6, 2022 at 6:44 AM Quentin Monnet <quentin@xxxxxxxxxxxxx> wrote: > > The JIT disassembler in bpftool is the only components (with the JSON > writer) using asserts to check the return values of functions. But it > does not do so in a consistent way, and diasm_print_insn() returns no > value, although sometimes the operation failed. > > Remove the asserts, and instead check the return values, print messages > on errors, and propagate the error to the caller from prog.c. > > Remove the inclusion of assert.h from jit_disasm.c, and also from map.c > where it is unused. > > Signed-off-by: Quentin Monnet <quentin@xxxxxxxxxxxxx> Acked-by: Song Liu <song@xxxxxxxxxx>