Hi, On 9/5/2022 10:33 PM, Roberto Sassu wrote: > From: Roberto Sassu <roberto.sassu@xxxxxxxxxx> > > Export bpf_dynptr_get_size(), so that kernel code dealing with eBPF dynamic > pointers can obtain the real size of data carried by this data structure. > > Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx> > Reviewed-by: Joanne Koong <joannelkoong@xxxxxxxxx> > Acked-by: KP Singh <kpsingh@xxxxxxxxxx> > --- > include/linux/bpf.h | 1 + > kernel/bpf/helpers.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) SNIP > diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c > index fc08035f14ed..824864ac82d1 100644 > --- a/kernel/bpf/helpers.c > +++ b/kernel/bpf/helpers.c > @@ -1408,7 +1408,7 @@ static void bpf_dynptr_set_type(struct bpf_dynptr_kern *ptr, enum bpf_dynptr_typ > ptr->size |= type << DYNPTR_TYPE_SHIFT; > } > > -static u32 bpf_dynptr_get_size(struct bpf_dynptr_kern *ptr) > +u32 bpf_dynptr_get_size(struct bpf_dynptr_kern *ptr) > { > return ptr->size & DYNPTR_SIZE_MASK; > } qp-trie also need it. But considering bpf_dynptr_get_size() is just one line, Would moving it and the related definitions into bpf.h be a better choice ?