Use __tcf_generic_walker() and __tcf_idr_search() helpers by saving nat_net_id when registering act_nat_ops. And then remove the walk and lookup hook functions in act_nat. Signed-off-by: Zhengchao Shao <shaozhengchao@xxxxxxxxxx> --- net/sched/act_nat.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/net/sched/act_nat.c b/net/sched/act_nat.c index 2a39b3729e84..c95601bc738c 100644 --- a/net/sched/act_nat.c +++ b/net/sched/act_nat.c @@ -289,32 +289,14 @@ static int tcf_nat_dump(struct sk_buff *skb, struct tc_action *a, return -1; } -static int tcf_nat_walker(struct net *net, struct sk_buff *skb, - struct netlink_callback *cb, int type, - const struct tc_action_ops *ops, - struct netlink_ext_ack *extack) -{ - struct tc_action_net *tn = net_generic(net, nat_net_id); - - return tcf_generic_walker(tn, skb, cb, type, ops, extack); -} - -static int tcf_nat_search(struct net *net, struct tc_action **a, u32 index) -{ - struct tc_action_net *tn = net_generic(net, nat_net_id); - - return tcf_idr_search(tn, a, index); -} - static struct tc_action_ops act_nat_ops = { .kind = "nat", .id = TCA_ID_NAT, + .net_id = &nat_net_id, .owner = THIS_MODULE, .act = tcf_nat_act, .dump = tcf_nat_dump, .init = tcf_nat_init, - .walk = tcf_nat_walker, - .lookup = tcf_nat_search, .size = sizeof(struct tcf_nat), }; -- 2.17.1