Re: [PATCH bpf v2] bpf: Add config for skipping BTF enum64s

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/29/22 1:33 AM, Martin Rodriguez Reboredo wrote:
After the release of pahole 1.24 some people in the dwarves mailing list
notified issues related to building the kernel with the BTF_DEBUG_INFO
option toggled. They seem to be happenning due to the kernel and
resolve_btfids interpreting btf types erroneously. In the dwarves list
I've proposed a change to the scripts that I've written while testing
the Rust kernel, it simply passes the --skip_encoding_btf_enum64 to
pahole if it has version 1.24.

v1 -> v2:
- Switch to off by default and remove the config option.
- Send it to stable instead.

This should only go to stable and not to bpf tree, right? To which stable versions?
For stable tree submissions you'd need to send this to stable@xxxxxxxxxxxxxxx in Cc
and subject should say e.g. '[PATCH stable 5.4]' for 5.4 branch [0]. Either way, pls
clarify.

  [0] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/?h=linux-5.4.y

Thanks,
Daniel

Signed-off-by: Martin Rodriguez Reboredo <yakoyoku@xxxxxxxxx>
---
  scripts/pahole-flags.sh | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/scripts/pahole-flags.sh b/scripts/pahole-flags.sh
index 0d99ef17e4a5..0a48fd86bc68 100755
--- a/scripts/pahole-flags.sh
+++ b/scripts/pahole-flags.sh
@@ -19,5 +19,8 @@ fi
  if [ "${pahole_ver}" -ge "122" ]; then
  	extra_paholeopt="${extra_paholeopt} -j"
  fi
+if [ "${pahole_ver}" -ge "124" ]; then
+	extra_paholeopt="${extra_paholeopt} --skip_encoding_btf_enum64"
+fi
echo ${extra_paholeopt}





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux