On Sat, 27 Aug 2022 at 07:37, Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > On Fri, Aug 26, 2022 at 1:54 PM Kumar Kartikeya Dwivedi > <memxor@xxxxxxxxx> wrote: > > > > On Fri, 26 Aug 2022 at 21:49, Joanne Koong <joannelkoong@xxxxxxxxx> wrote: > > > > > > On Fri, Aug 26, 2022 at 11:52 AM Kumar Kartikeya Dwivedi > > > <memxor@xxxxxxxxx> wrote: > > > > > > > > On Fri, 26 Aug 2022 at 20:44, Joanne Koong <joannelkoong@xxxxxxxxx> wrote: > > > > > > > > > > On Thu, Aug 25, 2022 at 5:19 PM Kumar Kartikeya Dwivedi > > > > > <memxor@xxxxxxxxx> wrote: > > > > > > > > > > > > On Thu, 25 Aug 2022 at 23:02, Joanne Koong <joannelkoong@xxxxxxxxx> wrote: > > > > > > > [...] > > > > > > > > > > > > > > > > Related question, it seems we know statically if dynptr is read only > > > > > > > > or not, so why even do all this hidden parameter passing and instead > > > > > > > > just reject writes directly? You only need to be able to set > > > > > > > > MEM_RDONLY on dynptr_data returned PTR_TO_PACKETs, and reject > > > > > > > > dynptr_write when dynptr type is xdp/skb (and ctx is only one). That > > > > > > > > seems simpler than checking it at runtime. Verifier already handles > > > > > > > > MEM_RDONLY generically, you only need to add the guard for > > > > > > > > check_packet_acces (and check_helper_mem_access for meta->raw_mode > > > > > > > > under pkt case), and rejecting dynptr_write seems like a if condition. > > > > > > > > > > > > > > There will be other helper functions that do writes (eg memcpy to > > > > > > > dynptrs, strncpy to dynptrs, probe read user to dynptrs, hashing > > > > > > > dynptrs, ...) so it's more scalable if we reject these at runtime > > > > > > > rather than enforce these at the verifier level. I also think it's > > > > > > > cleaner to keep the verifier logic as simple as possible and do the > > > > > > > checking in the helper. > > > > > > > > > > > > I won't be pushing this further, since you know what you plan to add > > > > > > in the future better, but I still disagree. > > > > > > > > > > > > I'm guessing there might be dynptrs where this read only property is > > > > > > set dynamically at runtime, which is why you want to go this route? > > > > > > I.e. you might not know statically whether dynptr is read only or not? > > > > > > > > > > > > My main confusion is the inconsistency here. > > > > > > > > > > > > Right now the patch implicitly relies on may_access_direct_pkt_data to > > > > > > protect slices returned from dynptr_data, instead of setting > > > > > > MEM_RDONLY on the returned PTR_TO_PACKET. Which is fine, it's not > > > > > > needed. So indirectly, you are relying on knowing statically whether > > > > > > the dynptr is read only or not. But then you also set this bit at > > > > > > runtime. > > > > > > > > > > > > So you reject some cases at load time, and the rest of them only at > > > > > > runtime. Direct writes to dynptr slice fails load, writes through > > > > > > helper does not (only fails at runtime). > > > > > > > > > > > > Also, dynptr_data needs to know whether dynptr is read only > > > > > > statically, to protect writes to its returned pointer, unless you > > > > > > decide to introduce another helper for the dynamic rdonly bit case > > > > > > (like dynptr_data_rdonly). Then you have a mismatch, where dynptr_data > > > > > > works for some rdonly dynptrs (known to be rdonly statically, like > > > > > > this skb one), but not for others. > > > > > > > > > > > > I also don't agree about the complexity or scalability part, all the > > > > > > infra and precedence is already there. We already have similar checks > > > > > > for meta->raw_mode where we reject writes to read only pointers in > > > > > > check_helper_mem_access. > > > > > > > > > > My point about scalability is that if we reject bpf_dynptr_write() at > > > > > load time, then we must reject any future dynptr helper that does any > > > > > writing at load time as well, to be consistent. > > > > > > > > > > I don't feel strongly about whether we reject at load time or run > > > > > time. Rejecting at load time instead of runtime doesn't seem that > > > > > useful to me, but there's a good chance I'm wrong here since Martin > > > > > stated that he prefers rejecting at load time as well. > > > > > > > > > > As for the added complexity part, what I mean is that we'll need to > > > > > keep track of some more stuff to support this, such as whether the > > > > > dynptr is read only and which helper functions need to check whether > > > > > the dynptr is read only or not. > > > > > > > > What I'm trying to understand is how dynptr_data is supposed to work > > > > if this dynptr read only bit is only known at runtime. Or will it be > > > > always known statically so that it can set returned pointer as read > > > > only? Because then it doesn't seem it is required or useful to track > > > > the readonly bit at runtime. > > > > > > I think it'll always be known statically whether the dynptr is > > > read-only or not. If we make all writable dynptr helper functions > > > reject read-only dynptrs at load time instead of run time, then yes we > > > can remove the read-only bit in the bpf_dynptr_kern struct. > > > > > > There's also the question of whether this constraint (eg all read-only > > > writes are rejected at load time) is too rigid - for example, what if > > > in the future we want to add a helper function where if a certain > > > condition is met, then we write some number of bytes, else we read > > > some number of bytes? This would be not possible to add then, since > > > we'll only know at runtime whether the condition is met. > > > > > > I personally lean towards rejecting helper function writes at runtime, > > > but if you think it's a non-trivial benefit to reject at load time > > > instead, I'm fine going with that. > > > > > > > My personal opinion is this: > > > > When I am working with a statically known read only dynptr, it is like > > declaring a variable const. Every function expecting it to be > > non-const should fail compilation, and trying to mutate the variables > > through writes should also fail compilation. For BPF compilation is > > analogous to program load. > > > > It might be that said variable is not const, then those operations may > > fail at runtime due to some other reason. Being dynamically read-only > > is then a runtime failure condition, which will cause failure at > > runtime. Both are distinct cases in my mind, and it is fine to fail at > > runtime when we don't know. In general, you save a lot of time of the > > user in my opinion (esp. people new to things) if you reject known > > incorrectness as early as possible. > > > > E.g. load a dynptr from a map, where the field accepts storing both > > read only and non-read only ones. Then it is expected that writes may > > fail at runtime. That also allows you to switch read-only ness at > > runtime back to rw. But if the field only expects rdonly dynptr, > > verifier knows that the type is const statically, so it triggers > > failures for writes at load time instead. > > > > Taking this a step further, you may even store rw dynptr to a map > > field expecting rdonly dynptr. That's like returning a const pointer > > from a function for a rw memory, where you want to limit access of the > > user, even better if you do it statically. Then functions trying to > > write to dynptr loaded from said map field will fail load itself, > > while others having access to rw dynptr can do it just fine. > > > > When the verifier does not know, it does not know. There will be such > > cases when you make const-ness a runtime property. > > > > > > > > > > It is fine if _everything_ checks it at runtime, but that doesn't seem > > > > possible, hence the question. We would need a new slice helper that > > > > only returns read-only slices, because dynptr_data can return rw > > > > slices currently and it is already UAPI so changing that is not > > > > possible anymore. > > > > > > I don't agree that if bpf_dynptr_write() is checked at runtime, then > > > bpf_dynptr_data must also be checked at runtime to be consistent. I > > > think it's fine if writes through helper functions are rejected at > > > runtime, and writes through direct access are rejected at load time. > > > That doesn't seem inconsistent to me. > > > > My point was more that dynptr_data cannot propagate runtime > > read-only-ness to its returned pointer. The verifier has to know > > statically, at which point I don't see why we can't just reject other > > cases at load anyway. > > I think the right answer here is to not make bpf_dynptr_data() return > direct pointer of changing read-only-ness. Maybe the right answer here > is another helper, bpf_dynptr_data_rdonly(), that will return NULL for > non-read-only dynptr and PTR_TO_MEM | MEM_RDONLY if dynptr is indeed > read-only? Shouldn't it be the other way around? bpf_dynptr_data_rdonly() should work for both ro and rw dynptrs, and bpf_dynptr_data() only for rw dynptr? And yes, you're kind of painting yourself in a corner if you allow dynptr_data to work with statically ro dynptrs now, ascertaining the ro bit for the returned slice, and then later you plan to add dynptrs whose ro vs rw is not known to the verifier statically. Then it works well for statically known ones (returning both ro and rw slices), but has to return NULL at runtime for statically unknown read only ones, and always rw slice in verifier state for them. > > By saying that read-only-ness of dynptr should be statically known and > rejecting some dynptr functions at load time places us at the mercy of > verifier's complete knowledge of application logic, which is exactly > against the spirit of dynptr. > Right, that might be too restrictive if we require them to be statically read only. But it's not about forcing it to be statically ro, it is more about rejecting load when we know the program is incorrect (e.g. the types are incorrect when passed to helpers), otherwise we throw the error at runtime anyway, which seems to be the convention afaicu. But maybe I missed the memo and we gradually want to move away from such strict static checks. I view the situation here similar to if we were rejecting direct writes to PTR_TO_MEM | MEM_RDONLY at load time, but offloading as runtime check in the helper writing to it as rw memory arg. It's as if we pretend it's part of the 'type' of the register when doing direct writes, but then ignore it while matching it against the said helper's argument type. > It's only slightly tangential, but I still dread my experience proving > to BPF verifier that some value is strictly greater than zero for BPF > helper that expected ARG_CONST_SIZE (not ARG_CONST_SIZE_OR_ZERO). > There were also cases were absolutely correct program had to be > mangled just to prove to BPF verifier that it indeed can return just 0 > or 1, etc. This is not to bash BPF verifier, but just to point out > that sometimes unnecessary strictness adds nothing but unnecessary > pain to user. So, let's not reject anything at load, we can check all > that at runtime and return NULL. > > But bpf_dynptr_data_rdonly() seems useful for cases where we know we > are not going to write > > > > > When we have dynptrs which have const-ness as a runtime property, it > > is ok to support that by failing at runtime (but then you'll have a > > hard time deciding how you want dynptr_data to work, most likely > > you'll need another helper which returns only a rdonly slice, when it > > fails, we call dynptr_data for rw slice). > > > > But as I said before, I don't know how dynptr is going to evolve in > > the future, so you'll have a better idea, and I'll leave it up to you > > decide how you want to design its API. Enough words exchanged about > > this :). > > directionally, dynptr is about offloading decisions to runtime, so I > think avoiding unnecessary restrictions at verification time is the > right trade off Fair enough, I guess I've made my point. Let's go with what you both feel would be best.
