On 26/08/22 19:40, Ian Rogers wrote: > When fixing a locking race and memory leak in: > https://lore.kernel.org/linux-perf-users/20211118193714.2293728-1-irogers@xxxxxxxxxx/ > > It was requested that debug mutex code be separated out into its own > files. This was, in part, done by Pavithra Gurushankar in: > https://lore.kernel.org/lkml/20220727111954.105118-1-gpavithrasha@xxxxxxxxx/ > > These patches fix issues with the previous patches, add in the > original dso->nsinfo fix and then build on our mutex wrapper with > clang's -Wthread-safety analysis. The analysis found missing unlocks > in builtin-sched.c which are fixed and -Wthread-safety is enabled by > default when building with clang. > > v4. Adds a comment for the trylock result, fixes the new line (missed > in v3) and removes two blank lines as suggested by Adrian Hunter. > v3. Adds a missing new line to the error messages and removes the > pshared argument to mutex_init by having two functions, mutex_init > and mutex_init_pshared. These changes were suggested by Adrian Hunter. > v2. Breaks apart changes that s/pthread_mutex/mutex/g and the lock > annotations as requested by Arnaldo and Namhyung. A boolean is > added to builtin-sched.c to terminate thread funcs rather than > leaving them blocked on delted mutexes. > > Ian Rogers (17): > perf bench: Update use of pthread mutex/cond > perf tests: Avoid pthread.h inclusion > perf hist: Update use of pthread mutex > perf bpf: Remove unused pthread.h include > perf lock: Remove unused pthread.h include > perf record: Update use of pthread mutex > perf sched: Update use of pthread mutex > perf ui: Update use of pthread mutex > perf mmap: Remove unnecessary pthread.h include > perf dso: Update use of pthread mutex > perf annotate: Update use of pthread mutex > perf top: Update use of pthread mutex > perf dso: Hold lock when accessing nsinfo > perf mutex: Add thread safety annotations > perf sched: Fixes for thread safety analysis > perf top: Fixes for thread safety analysis > perf build: Enable -Wthread-safety with clang > > Pavithra Gurushankar (1): > perf mutex: Wrapped usage of mutex and cond For all patches except 9 and 16 Reviewed-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
